Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of configuration modification failure #1544

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jun 19, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

1、Fix the issue that configurations fail to be modified in the Kie environment of the configuration center.
2、Fix the problem that the old version of Nacos gets the wrong service status
3、Fix the problem that Zookeeper fails to query the configuration of other plug-ins.

Which issue(s) this PR fixes?

Fixes #1543

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 42.98% <0.00%> (+<0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
.../dynamicconfig/kie/listener/SubscriberManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/io/sermant/backend/service/ConfigService.java 29.28% <0.00%> (ø) 0.00 <0.00> (ø)
...rvice/dynamicconfig/zookeeper/ZooKeeperClient.java 24.69% <0.00%> (-0.31%) 0.00 <0.00> (ø)
...ervice/dynamicconfig/kie/client/kie/KieClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

lilai23
lilai23 previously approved these changes Jun 21, 2024
@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from a516449 to 3418b22 Compare June 24, 2024 08:16
@Sherlockhan Sherlockhan merged commit 170d85e into sermant-io:develop Jun 25, 2024
280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Configuration Management function test problems
4 participants