New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entity classes for config management in Backend #1529

Merged

Sherlockhan merged 1 commit into sermant-io:develop from hanbingleixue:develop

May 31, 2024

Collaborator

hanbingleixue commented May 31, 2024 •

edited by lilai23

Loading

What type of PR is this?

Feature.

What this PR does / why we need it?

Add entity class for configuration management in Backend.

Fixes #1528

Does this PR introduce a user-facing change?

No

Checklist

Make sure there is a GitHub_issue related with this PR before you start working on it.
Make sure you have squashed your change to one single commit.
GitHub Actions works fine in this PR.

codecov bot commented May 31, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Flag	Coverage Δ	Complexity Δ
unittests	`42.89% <0.00%> (-0.03%)`	`181.00 <0.00> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ	Complexity Δ
...ermant/backend/entity/config/ConfigCenterType.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...ermant/backend/entity/config/ConfigServerInfo.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...a/io/sermant/backend/entity/config/ConfigInfo.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../java/io/sermant/backend/entity/config/Result.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../sermant/backend/entity/config/ResultCodeType.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`

... and 7 files with indirect coverage changes

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/entity/config/ConfigInfo.java Outdated Show resolved Hide resolved

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/handler/config/PluginHandler.java Outdated Show resolved Hide resolved

hanbingleixue force-pushed the develop branch from 902edc9 to 96b8056 Compare

May 31, 2024 02:42

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/entity/config/ConfigInfo.java Show resolved Hide resolved

sermant-backend/src/main/java/io/sermant/backend/entity/config/ResultCodeType.java Outdated Show resolved Hide resolved

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/entity/config/ServiceType.java Outdated Show resolved Hide resolved

hanbingleixue force-pushed the develop branch from 96b8056 to d78f3af Compare

May 31, 2024 04:57

hanbingleixue changed the title ~~Add configuration management backend services~~ Add dynamically configured entity classes

hanbingleixue force-pushed the develop branch 2 times, most recently from c6ad011 to f62a836 Compare

May 31, 2024 06:11

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/entity/config/ResultCodeType.java Outdated Show resolved Hide resolved

daizhenyu previously approved these changes

View reviewed changes

hanbingleixue dismissed daizhenyu’s stale review via

6f78a1f

May 31, 2024 06:31

hanbingleixue force-pushed the develop branch from f62a836 to 6f78a1f Compare

May 31, 2024 06:31

lilai23 reviewed

View reviewed changes

sermant-backend/src/main/java/io/sermant/backend/entity/config/ConfigInfo.java Outdated Show resolved Hide resolved


          Add dynamically configured entity classes

66958e2

Signed-off-by: hanbingleixue <[email protected]>

hanbingleixue force-pushed the develop branch from 6f78a1f to 66958e2 Compare

May 31, 2024 06:49

lilai23 changed the title ~~Add dynamically configured entity classes~~ Add entity classes for config management in Backend

lilai23 approved these changes

View reviewed changes

daizhenyu approved these changes

View reviewed changes

Sherlockhan merged commit b110d00 into sermant-io:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet