Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback router. #1419

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

provenceee
Copy link
Collaborator

@provenceee provenceee commented Jan 17, 2024

【Fix issue】 #1405

[Modification] Added fallback routing, this function has been implemented in 1.0

[Use case description] Added ut

[Self-test situation] ut passed, local test passed

Signed-off-by: provenceee <[email protected]>
@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Jan 17, 2024
@provenceee provenceee self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9d1f090) 42.53% compared to head (305fce8) 42.82%.
Report is 12 commits behind head on develop.

Files Patch % Lines
...t/router/config/strategy/AbstractRuleStrategy.java 78.57% 1 Missing and 2 partials ⚠️
...eicloud/sermant/router/config/utils/RuleUtils.java 0.00% 3 Missing ⚠️
...sermant/router/dubbo/handler/FlowRouteHandler.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1419      +/-   ##
=============================================
+ Coverage      42.53%   42.82%   +0.29%     
- Complexity      3307     3367      +60     
=============================================
  Files            831      845      +14     
  Lines          18528    18757     +229     
  Branches        2043     2075      +32     
=============================================
+ Hits            7880     8033     +153     
- Misses          9661     9727      +66     
- Partials         987      997      +10     
Flag Coverage Δ
unittests 42.82% <78.78%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit a1fed04 into sermant-io:develop Jan 22, 2024
127 checks passed
@kkf1 kkf1 changed the title 增加fallback路由 add fallback router. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants