Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback routing #1408

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

provenceee
Copy link
Collaborator

@provenceee provenceee commented Jan 10, 2024

【Fix issue】 #1405

[Modification] Added fallback routing, this function has been implemented in 1.0

[Use case description] Added ut

[Self-test situation] ut passed, local test passed

@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Jan 10, 2024
@provenceee provenceee self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9d1f090) 42.53% compared to head (305fce8) 42.56%.
Report is 4 commits behind head on 1.3.x.

Files Patch % Lines
...t/router/config/strategy/AbstractRuleStrategy.java 78.57% 1 Missing and 2 partials ⚠️
...eicloud/sermant/router/config/utils/RuleUtils.java 0.00% 3 Missing ⚠️
...sermant/router/dubbo/handler/FlowRouteHandler.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              1.3.x    #1408      +/-   ##
============================================
+ Coverage     42.53%   42.56%   +0.03%     
- Complexity     3307     3316       +9     
============================================
  Files           831      831              
  Lines         18528    18546      +18     
  Branches       2043     2050       +7     
============================================
+ Hits           7880     7894      +14     
- Misses         9661     9665       +4     
  Partials        987      987              
Flag Coverage Δ
unittests 42.56% <78.78%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provenceee provenceee changed the title *增加fallback路由 增加fallback路由 Jan 10, 2024
Signed-off-by: provenceee <[email protected]>
@Sherlockhan Sherlockhan merged commit 6b68f85 into sermant-io:1.3.x Jan 16, 2024
64 checks passed
@kkf1 kkf1 changed the title 增加fallback路由 add fallback router Apr 13, 2024
@kkf1 kkf1 changed the title add fallback router add fallback routing Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants