-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fallback routing #1408
Merged
Merged
add fallback routing #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provenceee
added
kind/enhancement
Issues or PRs releated to sermant enhancement
area/plugin
Issues or PRs releated to sermant plugin service
labels
Jan 10, 2024
provenceee
requested review from
hanbingleixue,
lilai23,
luanwenfei-venus and
daizhenyu
January 10, 2024 06:36
provenceee
force-pushed
the
1.3.x-fallback
branch
from
January 10, 2024 06:42
235ecdb
to
5d5350c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 1.3.x #1408 +/- ##
============================================
+ Coverage 42.53% 42.56% +0.03%
- Complexity 3307 3316 +9
============================================
Files 831 831
Lines 18528 18546 +18
Branches 2043 2050 +7
============================================
+ Hits 7880 7894 +14
- Misses 9661 9665 +4
Partials 987 987
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lilai23
reviewed
Jan 11, 2024
...ommon/src/main/java/com/huaweicloud/sermant/router/config/strategy/AbstractRuleStrategy.java
Show resolved
Hide resolved
lilai23
reviewed
Jan 11, 2024
...outer-config-common/src/main/java/com/huaweicloud/sermant/router/config/utils/RuleUtils.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Jan 11, 2024
...ice/src/test/java/com/huaweicloud/sermant/router/dubbo/strategy/RuleStrategyHandlerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/huaweicloud/sermant/router/dubbo/strategy/RuleStrategyHandlerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/huaweicloud/sermant/router/dubbo/strategy/RuleStrategyHandlerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: provenceee <[email protected]>
provenceee
force-pushed
the
1.3.x-fallback
branch
from
January 16, 2024 03:01
5d5350c
to
305fce8
Compare
daizhenyu
approved these changes
Jan 16, 2024
lilai23
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin
Issues or PRs releated to sermant plugin service
kind/enhancement
Issues or PRs releated to sermant enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】 #1405
[Modification] Added fallback routing, this function has been implemented in 1.0
[Use case description] Added ut
[Self-test situation] ut passed, local test passed