Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message queue consumption prohibition plugin: UT for kafka and related configuration. #1394

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Dec 25, 2023

【Fix issue】#1379

[Modification content] Add kakfa to prohibit consumption of interceptors, tool classes, controllers and configuration management related UT

[Use case description] Add code UT

[Self-test situation] 1. Local static check passed; 2. Except for the bytecode enhanced declarator and its auxiliary classes, UT's class coverage is 100%, method coverage is 67%, and line coverage is 61%

[Scope of influence] None

@lilai23 lilai23 force-pushed the mq_prohibition branch 2 times, most recently from 9fc97c4 to 9d4d0ea Compare December 25, 2023 10:22
@lilai23 lilai23 added area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test labels Dec 25, 2023
@lilai23 lilai23 added this to the v1.3.0 milestone Dec 25, 2023
@lilai23 lilai23 self-assigned this Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ba2312) 42.54% compared to head (0f31207) 42.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1394   +/-   ##
==========================================
  Coverage      42.54%   42.54%           
  Complexity      3306     3306           
==========================================
  Files            831      831           
  Lines          18516    18517    +1     
  Branches        2042     2042           
==========================================
+ Hits            7877     7878    +1     
  Misses          9651     9651           
  Partials         988      988           
Flag Coverage Δ
unittests 42.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 9d1f090 into sermant-io:develop Dec 29, 2023
152 checks passed
@kkf1 kkf1 changed the title 消息队列禁消费插件: kafka以及配置相关UT Message queue consumption prohibition plugin: UT for kafka and related configuration. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants