Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label routing matching fallback rule logic #1387

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

chengyouling
Copy link
Collaborator

@chengyouling chengyouling commented Dec 18, 2023

【Fix issue】#1386

[Modification content] Modify label routing to match fallback label logic

[Use case description] Add matching fallback label routing test case

[Self-test situation] Test case passed

[Scope of influence] Affects label routing function logic

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (10bed08) 46.33% compared to head (74b1b37) 46.58%.
Report is 1 commits behind head on 1.0.x.

Files Patch % Lines
...t/router/config/strategy/AbstractRuleStrategy.java 78.57% 1 Missing and 2 partials ⚠️
...a/com/huawei/registry/service/client/ScClient.java 33.33% 0 Missing and 2 partials ⚠️
...eicloud/sermant/router/dubbo/utils/RouteUtils.java 66.66% 1 Missing ⚠️
...ei/dubbo/registry/service/RegistryServiceImpl.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              1.0.x    #1387      +/-   ##
============================================
+ Coverage     46.33%   46.58%   +0.25%     
- Complexity     2934     2952      +18     
============================================
  Files           683      683              
  Lines         14817    14835      +18     
  Branches       1666     1675       +9     
============================================
+ Hits           6865     6911      +46     
+ Misses         7098     7058      -40     
- Partials        854      866      +12     
Flag Coverage Δ
unittests 46.58% <80.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengyouling chengyouling force-pushed the 1.0.x-fallback branch 2 times, most recently from dc7e2cd to cfbed4b Compare December 18, 2023 06:19
@chengyouling chengyouling force-pushed the 1.0.x-fallback branch 3 times, most recently from 6d8244e to 99e3f3d Compare December 18, 2023 09:55
provenceee
provenceee previously approved these changes Dec 18, 2023
provenceee
provenceee previously approved these changes Dec 18, 2023
@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Dec 19, 2023
Signed-off-by: chengyouling <[email protected]>

Signed-off-by: chengyouling <[email protected]>
@Sherlockhan Sherlockhan merged commit 514e698 into sermant-io:1.0.x Dec 19, 2023
53 checks passed
@kkf1 kkf1 changed the title 增加标签路由匹配fallback规则逻辑 Add label routing matching fallback rule logic Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants