Add label routing matching fallback rule logic #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengyouling
force-pushed
the
1.0.x-fallback
branch
from
9ad4394
to
cda6a91
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 1.0.x #1387 +/- ##
============================================
+ Coverage 46.33% 46.58% +0.25%
- Complexity 2934 2952 +18
============================================
Files 683 683
Lines 14817 14835 +18
Branches 1666 1675 +9
============================================
+ Hits 6865 6911 +46
+ Misses 7098 7058 -40
- Partials 854 866 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chengyouling
force-pushed
the
1.0.x-fallback
branch
2 times, most recently
from
dc7e2cd
to
cfbed4b
Compare
provenceee
reviewed
Dec 18, 2023
...ommon/src/main/java/com/huaweicloud/sermant/router/config/strategy/AbstractRuleStrategy.java
Show resolved
Hide resolved
chengyouling
force-pushed
the
1.0.x-fallback
branch
from
045556e
to
f1e8a84
Compare
provenceee
reviewed
Dec 18, 2023
...ommon/src/main/java/com/huaweicloud/sermant/router/config/strategy/AbstractRuleStrategy.java
Outdated
Show resolved
Hide resolved
chengyouling
force-pushed
the
1.0.x-fallback
branch
3 times, most recently
from
6d8244e
to
99e3f3d
Compare
provenceee
reviewed
Dec 18, 2023
...ommon/src/main/java/com/huaweicloud/sermant/router/config/strategy/AbstractRuleStrategy.java
Outdated
Show resolved
Hide resolved
chengyouling
force-pushed
the
1.0.x-fallback
branch
from
b3e0b3a
to
9b49ddd
Compare
provenceee
previously approved these changes
Dec 18, 2023
chengyouling
force-pushed
the
1.0.x-fallback
branch
from
7a1dd88
to
bc09176
Compare
provenceee
previously approved these changes
Dec 18, 2023
daizhenyu
reviewed
Dec 19, 2023
...ice/src/test/java/com/huaweicloud/sermant/router/dubbo/strategy/RuleStrategyHandlerTest.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/com/huaweicloud/sermant/router/dubbo/strategy/RuleStrategyHandlerTest.java
Outdated
Show resolved
Hide resolved
...ce/src/test/java/com/huaweicloud/sermant/router/spring/strategy/RuleStrategyHandlerTest.java
Show resolved
Hide resolved
provenceee
added
kind/enhancement
Signed-off-by: chengyouling <[email protected]> Signed-off-by: chengyouling <[email protected]>
chengyouling
force-pushed
the
1.0.x-fallback
branch
from
6ef5fe1
to
74b1b37
Compare
provenceee
approved these changes
Dec 19, 2023
daizhenyu
approved these changes
Dec 19, 2023
luanwenfei-venus
approved these changes
Dec 19, 2023
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1386
[Modification content] Modify label routing to match fallback label logic
[Use case description] Add matching fallback label routing test case
[Self-test situation] Test case passed
[Scope of influence] Affects label routing function logic