Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecheck bug fix #1369

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Codecheck bug fix #1369

merged 1 commit into from
Nov 24, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Nov 15, 2023

[Fix issue] #1365

【Modification】Fix the codecheck problem in the code

Plugin Codecheck
sermant-flowcontrol Public or protected method is missing annotation
sermant-flowcontrol Method header annotation is missing content
sermant-flowcontrol method is missing annotations for parameters, exceptions or return values
sermant-flowcontrol Double check lock acquisition singleton should add volatile to the singleton
sermant-flowcontrol uses custom compareTo but does not override the equals method
sermant-flowcontrol redundant constructor
sermant-flowcontrol No handling is done after catching the exception
sermant-flowcontrol The variable name must conform to the regular expression
sermant-flowcontrol long type uses L as suffix
sermant-loadbalancer The method lacks annotations for parameters, exceptions, or return values.
sermant-loadbalancer Deprecated methods need to add method comments
sermant-loadbalancer Type force transfer requires verification
sermant-loadbalancer File header format problem
sermant-monitor The variable name must conform to the regular expression
sermant-monitor The method is missing annotations for parameters, exceptions or return values
sermant-monitor Public or protected method is missing annotation
sermant-monitor Space indentation problem
sermant-injector Space indentation problem
sermant-integration-tests Missing package name
sermant-integration-tests py file naming problem
sermant-dynamic-config Variable names must conform to regular expressions

[Use case description] None

[Self-test situation] 1. Local static check passed

[Scope of influence] None

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (a1308ed) 42.83% compared to head (0d7de82) 42.12%.
Report is 16 commits behind head on develop.

Files Patch % Lines
...owcontrol/retry/ApacheDubboInvokerInterceptor.java 55.55% 4 Missing ⚠️
.../flowcontrol/inject/DefaultClientHttpResponse.java 0.00% 3 Missing ⚠️
...ud/loadbalancer/cache/RibbonLoadbalancerCache.java 0.00% 3 Missing ⚠️
...ud/loadbalancer/cache/SpringLoadbalancerCache.java 0.00% 3 Missing ⚠️
...wei/dynamic/config/DefaultDynamicConfigSource.java 33.33% 2 Missing ⚠️
...wei/flowcontrol/common/core/rule/AbstractRule.java 0.00% 2 Missing ⚠️
...awei/flowcontrol/service/InterceptorSupporter.java 0.00% 2 Missing ⚠️
.../flowcontrol/res4j/chain/AbstractChainHandler.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1369      +/-   ##
=============================================
- Coverage      42.83%   42.12%   -0.72%     
+ Complexity      3301     3276      -25     
=============================================
  Files            824      826       +2     
  Lines          18311    18406      +95     
  Branches        2018     2030      +12     
=============================================
- Hits            7844     7753      -91     
- Misses          9481     9678     +197     
+ Partials         986      975      -11     
Flag Coverage Δ
unittests 42.12% <44.73%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hanbingleixue
hanbingleixue previously approved these changes Nov 16, 2023
@lilai23 lilai23 force-pushed the codecheck branch 3 times, most recently from 22fb409 to 407bf02 Compare November 21, 2023 12:49
hanbingleixue
hanbingleixue previously approved these changes Nov 23, 2023
Signed-off-by: lilai <[email protected]>
@Sherlockhan Sherlockhan merged commit b3d1022 into sermant-io:develop Nov 24, 2023
67 checks passed
@kkf1 kkf1 changed the title codecheck问题修改 codecheck bug fix Apr 13, 2024
@kkf1 kkf1 changed the title codecheck bug fix Codecheck bug fix Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants