Fix the bug that host classes could be loaded from the plugin class loader. #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanwenfei-venus
added
kind/bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1353 +/- ##
=============================================
- Coverage 42.83% 42.78% -0.06%
+ Complexity 3301 3298 -3
=============================================
Files 824 824
Lines 18311 18322 +11
Branches 2018 2020 +2
=============================================
- Hits 7844 7839 -5
- Misses 9481 9499 +18
+ Partials 986 984 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
...re-core/src/main/java/com/huaweicloud/sermant/core/plugin/classloader/PluginClassLoader.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/huaweicloud/sermant/core/plugin/classloader/PluginClassLoader.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
force-pushed
the
develop_issue_1352
branch
from
fd9422b to
baf706a
Compare
lilai23
reviewed
Nov 3, 2023
...re-core/src/main/java/com/huaweicloud/sermant/core/plugin/classloader/PluginClassLoader.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
force-pushed
the
develop_issue_1352
branch
from
baf706a to
709d0ff
Compare
hanbingleixue
previously approved these changes
Nov 3, 2023
luanwenfei-venus
force-pushed
the
develop_issue_1352
branch
from
709d0ff to
6c13148
Compare
hanbingleixue
approved these changes
Nov 6, 2023
lilai23
approved these changes
Nov 6, 2023
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1352
[Modification content] 1. Added the plug-in class loader to load from itself first. 2. Modified the cache field name for plug-in service class loading.
[Use case description] Not involved
[Self-test situation] 1. The local static check has been cleared; 2. The threshold use case passed
[Scope of influence] Not involved