Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global routing rules. #1317

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

provenceee
Copy link
Collaborator

@provenceee provenceee commented Sep 20, 2023

【Fix issue】 #1316

[Modification content] Add global routing rules

[Self-test situation] 1. Configure global routing rules, and global routing takes effect. 2. Configure global routing and service-level routing at the same time, and service-level routing takes effect.

[Scope of Impact] Supplementary Documents

@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Sep 20, 2023
@provenceee provenceee self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 32.60% and project coverage change: -0.30% ⚠️

Comparison is base (6dd5d2e) 46.62% compared to head (10bed08) 46.33%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.0.x    #1317      +/-   ##
============================================
- Coverage     46.62%   46.33%   -0.30%     
+ Complexity     2942     2934       -8     
============================================
  Files           682      683       +1     
  Lines         14783    14817      +34     
  Branches       1663     1666       +3     
============================================
- Hits           6893     6865      -28     
- Misses         7026     7098      +72     
+ Partials        864      854      -10     
Flag Coverage Δ
unittests 46.33% <32.60%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ant/router/config/handler/GlobalConfigHandler.java 0.00% <0.00%> (ø)
...t/router/config/listener/RouterConfigListener.java 0.00% <0.00%> (ø)
...router/spring/service/LoadBalancerServiceImpl.java 88.46% <0.00%> (ø)
...mant/router/config/entity/RouterConfiguration.java 58.82% <36.36%> (-26.90%) ⬇️
...oud/sermant/router/common/config/RouterConfig.java 69.56% <50.00%> (-1.87%) ⬇️
...er/dubbo/service/AbstractDirectoryServiceImpl.java 88.88% <100.00%> (ø)
.../sermant/router/config/entity/EnabledStrategy.java 100.00% <100.00%> (ø)
...eicloud/sermant/router/config/utils/RuleUtils.java 52.05% <100.00%> (+1.38%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lilai23
lilai23 previously approved these changes Sep 20, 2023
@Sherlockhan Sherlockhan merged commit 2ed4003 into sermant-io:1.0.x Sep 22, 2023
42 checks passed
@kkf1 kkf1 changed the title 增加全局路由规则 Add global routing rules. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants