-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global routing rules. #1317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provenceee
added
kind/enhancement
Issues or PRs releated to sermant enhancement
area/plugin
Issues or PRs releated to sermant plugin service
labels
Sep 20, 2023
provenceee
requested review from
hanbingleixue,
lilai23 and
luanwenfei-venus
September 20, 2023 07:52
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 1.0.x #1317 +/- ##
============================================
- Coverage 46.62% 46.33% -0.30%
+ Complexity 2942 2934 -8
============================================
Files 682 683 +1
Lines 14783 14817 +34
Branches 1663 1666 +3
============================================
- Hits 6893 6865 -28
- Misses 7026 7098 +72
+ Partials 864 854 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lilai23
previously approved these changes
Sep 20, 2023
...service/src/main/java/com/huaweicloud/sermant/router/config/handler/GlobalConfigHandler.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/com/huaweicloud/sermant/router/config/handler/GlobalConfigHandler.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/com/huaweicloud/sermant/router/config/handler/GlobalConfigHandler.java
Outdated
Show resolved
Hide resolved
...g-common/src/main/java/com/huaweicloud/sermant/router/config/entity/RouterConfiguration.java
Show resolved
Hide resolved
...outer-config-common/src/main/java/com/huaweicloud/sermant/router/config/utils/RuleUtils.java
Show resolved
Hide resolved
provenceee
force-pushed
the
global-router
branch
from
September 21, 2023 12:22
6509df4
to
10bed08
Compare
luanwenfei-venus
approved these changes
Sep 21, 2023
lilai23
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin
Issues or PRs releated to sermant plugin service
kind/enhancement
Issues or PRs releated to sermant enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】 #1316
[Modification content] Add global routing rules
[Self-test situation] 1. Configure global routing rules, and global routing takes effect. 2. Configure global routing and service-level routing at the same time, and service-level routing takes effect.
[Scope of Impact] Supplementary Documents