AgentCore uninstallation and plugin uninstallation #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanwenfei-venus
added
kind/feature
luanwenfei-venus
force-pushed
the
develop_issue_1236_for_uninstall_plugin
branch
3 times, most recently
from
7e8f477 to
20e4f7c
Compare
luanwenfei-venus
requested review from
lilai23,
HapThorin and
TangLeDaily
and removed request for
HapThorin
luanwenfei-venus
force-pushed
the
develop_issue_1236_for_uninstall_plugin
branch
from
20e4f7c to
aaa10ed
Compare
lilai23
reviewed
Sep 15, 2023
...ore/sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/AgentCoreEntrance.java
Show resolved
Hide resolved
...ore/sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/AgentCoreEntrance.java
Show resolved
Hide resolved
...re/sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/event/EventManager.java
Outdated
Show resolved
Hide resolved
.../sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
.../sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
.../sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
.../sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/config/ConfigManager.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
force-pushed
the
develop_issue_1236_for_uninstall_plugin
branch
from
aaa10ed to
dd61806
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1308 +/- ##
=============================================
- Coverage 42.65% 42.49% -0.16%
- Complexity 3313 3314 +1
=============================================
Files 834 833 -1
Lines 18405 18467 +62
Branches 2000 2013 +13
=============================================
- Hits 7851 7848 -3
- Misses 9579 9644 +65
Partials 975 975
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
luanwenfei-venus
force-pushed
the
develop_issue_1236_for_uninstall_plugin
branch
from
dd61806 to
524a11d
Compare
TangLeDaily
previously approved these changes
Sep 15, 2023
luanwenfei-venus
force-pushed
the
develop_issue_1236_for_uninstall_plugin
branch
from
524a11d to
e76813d
Compare
TangLeDaily
approved these changes
Sep 15, 2023
lilai23
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1236
[Modification content] 1. Agent uninstallation logic 2. Plug-in uninstallation logic 3. TimeUtil in the heartbeat service has been deleted, which is useless and occupied by extra threads
[Use case description] 1. Test cases have been added
[Self-test situation] 1. The local static check has an Exception that the framework needs to be replenished and cannot pass; 2. UT is subsequently merged.
[Scope of impact] 1. Is there any impact on users' use (such as API modifications and startup parameter modifications)? 2. Is it necessary to update some documents (such as user manuals)