Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command parsing executor for dynamic installation and uninstallation #1305

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Sep 11, 2023

【Fix issue】#1236

【Modified content】

  1. Modify parameter parsing to support dynamic installation and uninstallation of commands in the format similar to INSTALL-PLUGINS:[monitor].
  2. Add command parsing for dynamic installation and uninstallation
  3. Add a command executor for plug-in installation, uninstallation, and agent uninstallation (currently there is no specific execution logic)

[Use case description] 1. Subsequent supplementary use cases

[Self-test situation] 1. The local static check passed. 2. Passed the function self-test

[Scope of Impact] 1. User manual will be added in the future

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.20% ⚠️

Comparison is base (1823cec) 42.85% compared to head (1d1266a) 42.66%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1305      +/-   ##
=============================================
- Coverage      42.85%   42.66%   -0.20%     
+ Complexity      3315     3314       -1     
=============================================
  Files            829      834       +5     
  Lines          18357    18405      +48     
  Branches        1997     2000       +3     
=============================================
- Hits            7867     7852      -15     
- Misses          9505     9578      +73     
+ Partials         985      975      -10     
Flag Coverage Δ
unittests 42.66% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nt/core/command/AgentUnInstallCommandExecutor.java 0.00% <0.00%> (ø)
.../com/huaweicloud/sermant/core/command/Command.java 0.00% <0.00%> (ø)
...eicloud/sermant/core/command/CommandProcessor.java 0.00% <0.00%> (ø)
...nt/core/command/PluginsInstallCommandExecutor.java 0.00% <0.00%> (ø)
.../core/command/PluginsUnInstallCommandExecutor.java 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanbingleixue hanbingleixue force-pushed the install branch 3 times, most recently from ab959d4 to 7fcf5af Compare September 12, 2023 07:36
lilai23
lilai23 previously approved these changes Sep 13, 2023
@Sherlockhan Sherlockhan merged commit 1d0fcd9 into sermant-io:develop Sep 15, 2023
@kkf1 kkf1 changed the title 增加动态安装卸载的命令解析执行器 Add command parsing executor for dynamic installation and uninstallation Apr 13, 2024
@hanbingleixue hanbingleixue deleted the install branch August 31, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants