Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

流量标签透传插件 dubbo、sofarpc、servicecombrpc UT #1296

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

daizhenyu
Copy link
Collaborator

【修复issue】#1244

【修改内容】增加了流量标签透传插件dubbo、sofarpc、servicecombrpc部分 的UT

【用例描述】不需要

【自测情况】1、本地静态检查通过;2、dubbo部分 UT覆盖率为86%,sofarpc部分UT覆盖率为86%,servicecombrpc部分UT覆盖率为87%

【影响范围】无

@daizhenyu daizhenyu added the kind/unit-test Issues or PRs releated to sermant test label Sep 4, 2023
@daizhenyu daizhenyu added this to the v1.2.0 milestone Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (64d7eeb) 41.30% compared to head (6358bcc) 41.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1296   +/-   ##
==========================================
  Coverage      41.30%   41.30%           
- Complexity      3222     3223    +1     
==========================================
  Files            827      827           
  Lines          18287    18287           
  Branches        1991     1991           
==========================================
+ Hits            7553     7554    +1     
+ Misses          9783     9782    -1     
  Partials         951      951           
Flag Coverage Δ
unittests 41.30% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lilai23
lilai23 previously approved these changes Sep 8, 2023
lilai23
lilai23 previously approved these changes Sep 8, 2023
@daizhenyu daizhenyu added area/plugin Issues or PRs releated to sermant plugin service and removed kind/feature Issue for new feature labels Sep 8, 2023
@Sherlockhan Sherlockhan merged commit dbf95d7 into sermant-io:develop Sep 11, 2023
3 checks passed
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants