Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

流量标签透传支持servicecombrpc2.0+版本 #1291

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

daizhenyu
Copy link
Collaborator

【修复issue】#1244

【修改内容】增加了ServiceCombRpcConsumerDeclarer、ServiceCombRpcProviderDeclarer、ServiceCombRpcConsumerInterceptor和ServiceCombRpcProviderInterceptor,用于拦截servicecombrpc的客户端和服务端以支持流量标签透传

【用例描述】不涉及

【自测情况】1、本地静态检查通过;2、UT后续pr补充

【影响范围】后续更新插件使用手册

@daizhenyu daizhenyu added kind/feature Issue for new feature area/plugin Issues or PRs releated to sermant plugin service labels Aug 28, 2023
@daizhenyu daizhenyu added this to the v1.2.0 milestone Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.23% ⚠️

Comparison is base (e3ba25d) 42.20% compared to head (9bca815) 41.98%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1291      +/-   ##
=============================================
- Coverage      42.20%   41.98%   -0.23%     
  Complexity      3220     3220              
=============================================
  Files            821      824       +3     
  Lines          17894    17984      +90     
  Branches        1950     1953       +3     
=============================================
- Hits            7553     7551       -2     
- Misses          9389     9480      +91     
- Partials         952      953       +1     
Flag Coverage Δ
unittests 41.98% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daizhenyu daizhenyu force-pushed the develop-servicecomb-tag branch from 3395c6f to 4c4924f Compare August 29, 2023 08:11
hanbingleixue
hanbingleixue previously approved these changes Aug 29, 2023
lilai23
lilai23 previously approved these changes Aug 29, 2023
@daizhenyu daizhenyu dismissed stale reviews from lilai23 and hanbingleixue via 191d306 August 30, 2023 02:22
@daizhenyu daizhenyu force-pushed the develop-servicecomb-tag branch from 4c4924f to 191d306 Compare August 30, 2023 02:22
@daizhenyu daizhenyu force-pushed the develop-servicecomb-tag branch from 191d306 to 9bca815 Compare August 30, 2023 02:43
@Sherlockhan Sherlockhan merged commit 5814e18 into sermant-io:develop Aug 30, 2023
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants