Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

流量标签透传插件支持grpc框架 #1288

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Aug 23, 2023

【修复issue】#1244

【修改内容】1. 增加了流量标签透传插件支持grpc框架的声明器和拦截器,用于拦截grpc的客户端和服务端透传流量标签。2. 修改了跨线程流量标签透传模块,增加了runnable包装类处理特殊线程池的逻辑,避免误删线程内的流量标签。

【用例描述】不涉及

【自测情况】1、本地静态检查清理通过;2、UT后续pr补充

【影响范围】1、插件使用手册

@daizhenyu daizhenyu added kind/feature Issue for new feature area/plugin Issues or PRs releated to sermant plugin service labels Aug 23, 2023
@daizhenyu daizhenyu added this to the v1.2.0 milestone Aug 23, 2023
@luanwenfei-venus luanwenfei-venus changed the title Sermant流量标签透传插件支持grpc框架 流量标签透传插件支持grpc框架 Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.69% ⚠️

Comparison is base (5814e18) 41.98% compared to head (f807a95) 41.30%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1288      +/-   ##
=============================================
- Coverage      41.98%   41.30%   -0.69%     
- Complexity      3220     3222       +2     
=============================================
  Files            824      827       +3     
  Lines          17984    18287     +303     
  Branches        1953     1991      +38     
=============================================
+ Hits            7551     7553       +2     
- Misses          9480     9783     +303     
+ Partials         953      951       -2     
Flag Coverage Δ
unittests 41.30% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daizhenyu daizhenyu force-pushed the develop-grpc-tag branch 3 times, most recently from 33c4b94 to de62a3b Compare August 30, 2023 07:17
lilai23
lilai23 previously approved these changes Aug 31, 2023
hanbingleixue
hanbingleixue previously approved these changes Aug 31, 2023
@daizhenyu daizhenyu dismissed stale reviews from hanbingleixue and lilai23 via e12b92d September 1, 2023 07:01
@daizhenyu daizhenyu force-pushed the develop-grpc-tag branch 2 times, most recently from e12b92d to e9410ca Compare September 5, 2023 07:48
@Sherlockhan Sherlockhan merged commit 98d9cad into sermant-io:develop Sep 7, 2023
3 checks passed
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants