Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

流量标签透传特性:httpclient3、Okhttp2、Jdk httpclient补充UT & 优化现有UT #1286

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Aug 18, 2023

【修复issue】#1244

【修改内容】httpclient3、Okhttp2、Jdk httpclient 拦截器单元测试

【用例描述】详见UT

【自测情况】1、本地静态检查通过;2、当前UT覆盖率crossthread94%,http80%,mq73%

【影响范围】无

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16% ⚠️

Comparison is base (09f771e) 42.34% compared to head (a292898) 42.19%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1286      +/-   ##
=============================================
- Coverage      42.34%   42.19%   -0.16%     
+ Complexity      3230     3220      -10     
=============================================
  Files            821      821              
  Lines          17895    17894       -1     
  Branches        1947     1950       +3     
=============================================
- Hits            7578     7550      -28     
- Misses          9365     9391      +26     
- Partials         952      953       +1     
Flag Coverage Δ
unittests 42.19% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilai23 lilai23 added area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test labels Aug 18, 2023
@lilai23 lilai23 self-assigned this Aug 18, 2023
hanbingleixue
hanbingleixue previously approved these changes Aug 24, 2023
httpclient3、Okhttp2、Jdk httpclient 拦截器UT
@Sherlockhan Sherlockhan merged commit e3ba25d into sermant-io:develop Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants