-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
流量标签透传特性:支持跨线程传递标签 #1268
Merged
Merged
流量标签透传特性:支持跨线程传递标签 #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1268 +/- ##
=============================================
+ Coverage 42.00% 42.65% +0.65%
- Complexity 3197 3230 +33
=============================================
Files 815 816 +1
Lines 17740 17762 +22
Branches 1934 1935 +1
=============================================
+ Hits 7451 7576 +125
+ Misses 9358 9234 -124
- Partials 931 952 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lilai23
added
kind/feature
Issue for new feature
area/plugin
Issues or PRs releated to sermant plugin service
labels
Aug 2, 2023
...n-plugin/src/main/java/com/huaweicloud/sermant/tag/transmission/wrapper/AbstractWrapper.java
Outdated
Show resolved
Hide resolved
...n-plugin/src/main/java/com/huaweicloud/sermant/tag/transmission/wrapper/AbstractWrapper.java
Outdated
Show resolved
Hide resolved
...aweicloud/sermant/tag/transmission/interceptors/crossthread/AbstractExecutorInterceptor.java
Outdated
Show resolved
Hide resolved
...aweicloud/sermant/tag/transmission/interceptors/crossthread/AbstractExecutorInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
force-pushed
the
tag_trans
branch
3 times, most recently
from
August 8, 2023 08:00
15d9bee
to
b7c34ac
Compare
luanwenfei-venus
previously approved these changes
Aug 8, 2023
...n-plugin/src/main/java/com/huaweicloud/sermant/tag/transmission/wrapper/AbstractWrapper.java
Outdated
Show resolved
Hide resolved
...aweicloud/sermant/tag/transmission/interceptors/crossthread/AbstractExecutorInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
force-pushed
the
tag_trans
branch
2 times, most recently
from
August 8, 2023 11:20
852b5eb
to
6f835d5
Compare
luanwenfei-venus
previously approved these changes
Aug 9, 2023
支持跨线程传递标签,该能力可单独使用,可与路由等其他插件配合传递请求信息。
hanbingleixue
approved these changes
Aug 9, 2023
luanwenfei-venus
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】#1244
【修改内容】支持跨线程传递标签,该能力可单独使用,可与其他插件配合获取和传递请求信息。
该能力从路由插件中抽出,路由插件后续需相应重构适配。
【用例描述】1、直接new thread创建新线程,测试结果父线程的标签可以在子线程中获取;2、通过ExecutorService的submit、execute方法创建新线程,测试结果父线程的标签可以在子线程中获取;3、通过ScheduledExecutorService的schedule、scheduleAtFixedRate、scheduleWithFixedDelay方法创建新线程,测试结果父线程的标签可以在子线程中获取;
【自测情况】1、本地静态检查通过;2、本地自测通过
【影响范围】当前PR和流量标签透传插件不影响其他插件使用;后续需重构路由插件。