Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复springcloud双注册场景,使用zk注册中心有可能无法去重的bug #1264

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

TangLeDaily
Copy link
Collaborator

【修复issue】#1241

【修改内容】
修改了com.huawei.registry.interceptors.cloud3.x.ZookeeperInstanceSupplierInterceptor中convertAndMerge()方法去重方式

【用例描述】功能不变,不需要修改用例

【自测情况】本地静态检查通过、UT通过、去重测试通过

【影响范围】不涉及

@TangLeDaily TangLeDaily changed the title 【fix】修复springcloud双注册场景,使用zk注册中心有可能无法去重的bug 修复springcloud双注册场景,使用zk注册中心有可能无法去重的bug Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.02% 🎉

Comparison is base (2556a16) 45.53% compared to head (404c4d7) 45.56%.
Report is 3 commits behind head on 1.0.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.0.x    #1264      +/-   ##
============================================
+ Coverage     45.53%   45.56%   +0.02%     
- Complexity     2921     2924       +3     
============================================
  Files           676      676              
  Lines         14946    14952       +6     
  Branches       1678     1679       +1     
============================================
+ Hits           6806     6813       +7     
  Misses         7296     7296              
+ Partials        844      843       -1     
Flag Coverage Δ
unittests 45.56% <93.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ter/spring/declarer/ClientHttpRequestDeclarer.java 0.00% <ø> (ø)
...ring/interceptor/ClientHttpRequestInterceptor.java 90.00% <80.00%> (ø)
...cloud3/x/ZookeeperInstanceSupplierInterceptor.java 79.16% <100.00%> (+6.94%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit b360faf into sermant-io:1.0.x Jul 29, 2023
@TangLeDaily TangLeDaily added kind/bug Something isn't working area/plugin Issues or PRs releated to sermant plugin service labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants