Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正插件获取PluginService及PluginConfig的方法 #1240

Merged

Conversation

luanwenfei-venus
Copy link
Collaborator

【修复issue】#1239

【修改内容】1、修改插件获取PluginConfig为通过PluginConfigManager::getConfig 2、修改插件获取PluginService为通过PluginServiceManager::getService

【用例描述】不许修改,无功能新增

【自测情况】1、本地静态检查清理情况;

【影响范围】1、对用户的使用有没有影响 2、不涉及文档修改

@luanwenfei-venus luanwenfei-venus added area/plugin Issues or PRs releated to sermant plugin service kind/refactor labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 72.36% and project coverage change: -0.01 ⚠️

Comparison is base (07f7474) 41.64% compared to head (5680849) 41.64%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1240      +/-   ##
=============================================
- Coverage      41.64%   41.64%   -0.01%     
- Complexity      3203     3219      +16     
=============================================
  Files            811      817       +6     
  Lines          17939    18032      +93     
  Branches        1952     1961       +9     
=============================================
+ Hits            7471     7509      +38     
- Misses          9531     9578      +47     
- Partials         937      945       +8     
Flag Coverage Δ
unittests 41.64% <72.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubbo/interceptor/AbstractDirectoryInterceptor.java 0.00% <0.00%> (ø)
...ter/dubbo/interceptor/ClusterUtilsInterceptor.java 0.00% <0.00%> (ø)
...ubbo/interceptor/SpringApplicationInterceptor.java 0.00% <0.00%> (ø)
...er/spring/interceptor/RouteHandlerInterceptor.java 0.00% <0.00%> (ø)
.../dubbo/registry/alibaba/ServiceCenterRegistry.java 0.00% <0.00%> (ø)
...i/dubbo/registry/apache/ServiceCenterRegistry.java 0.00% <0.00%> (ø)
.../interceptor/ApacheInterfaceConfigInterceptor.java 0.00% <0.00%> (ø)
...stry/interceptor/ApplicationConfigInterceptor.java 0.00% <0.00%> (ø)
...stry/interceptor/SpringApplicationInterceptor.java 0.00% <0.00%> (ø)
...awei/flowcontrol/service/InterceptorSupporter.java 41.79% <50.00%> (ø)
... and 27 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sherlockhan Sherlockhan merged commit 3fb63d0 into sermant-io:develop Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants