Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加Agent通知逻辑 #1232

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jun 25, 2023

【修复issue】#1231

【修改内容】
1、增加AgentCore事件通知

【用例描述】
1、已增加UT

【自测情况】
1、本地静态检查通过
2、自测通过

【影响范围】
1、对用户的使用存在影响,后续增加用户使用手册。

@hanbingleixue hanbingleixue added kind/feature Issue for new feature area/framework Issues or PRs releated to sermant core service area/backend Issues or PRs releated to sermant backend service area/plugin Issues or PRs releated to sermant plugin service labels Jun 25, 2023
@hanbingleixue hanbingleixue force-pushed the develop branch 6 times, most recently from a40812e to 15edfa8 Compare June 25, 2023 06:58
@hanbingleixue hanbingleixue changed the title 增加Agent通知逻辑。并且优化服务可见性代码。 增加Agent通知逻辑 Jun 25, 2023
@hanbingleixue hanbingleixue removed area/backend Issues or PRs releated to sermant backend service area/plugin Issues or PRs releated to sermant plugin service labels Jun 25, 2023
@hanbingleixue hanbingleixue force-pushed the develop branch 5 times, most recently from 3061400 to 02fc0ad Compare June 25, 2023 09:17
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.11 🎉

Comparison is base (925b052) 41.65% compared to head (aa851ca) 41.77%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1232      +/-   ##
=============================================
+ Coverage      41.65%   41.77%   +0.11%     
- Complexity      3204     3226      +22     
=============================================
  Files            811      817       +6     
  Lines          17939    18029      +90     
  Branches        1952     1960       +8     
=============================================
+ Hits            7473     7532      +59     
- Misses          9530     9551      +21     
- Partials         936      946      +10     
Flag Coverage Δ
unittests 41.77% <40.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/huaweicloud/sermant/core/AgentCoreEntrance.java 0.00% <0.00%> (ø)
...ant/core/notification/SermantNotificationType.java 0.00% <0.00%> (ø)
...t/core/notification/ZookeeperNotificationType.java 0.00% <0.00%> (ø)
...mant/implement/service/send/netty/NettyClient.java 1.08% <0.00%> (-0.09%) ⬇️
...namicconfig/zookeeper/ZooKeeperBufferedClient.java 33.33% <25.00%> (-0.53%) ⬇️
...ud/sermant/core/notification/NotificationInfo.java 41.66% <41.66%> (ø)
...sermant/core/notification/NotificationManager.java 58.06% <58.06%> (ø)
...rmant/core/notification/NettyNotificationType.java 77.77% <77.77%> (ø)
...t/core/notification/config/NotificationConfig.java 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 7e40527 to c9bbe81 Compare June 27, 2023 12:46
@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 1585a5b to be97e20 Compare June 28, 2023 10:08
@Sherlockhan Sherlockhan merged commit dc24ef2 into sermant-io:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/feature Issue for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants