-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加Agent通知逻辑 #1232
Merged
Merged
增加Agent通知逻辑 #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanbingleixue
added
kind/feature
Issue for new feature
area/framework
Issues or PRs releated to sermant core service
area/backend
Issues or PRs releated to sermant backend service
area/plugin
Issues or PRs releated to sermant plugin service
labels
Jun 25, 2023
hanbingleixue
force-pushed
the
develop
branch
6 times, most recently
from
June 25, 2023 06:58
a40812e
to
15edfa8
Compare
hanbingleixue
removed
area/backend
Issues or PRs releated to sermant backend service
area/plugin
Issues or PRs releated to sermant plugin service
labels
Jun 25, 2023
hanbingleixue
force-pushed
the
develop
branch
5 times, most recently
from
June 25, 2023 09:17
3061400
to
02fc0ad
Compare
luanwenfei-venus
previously approved these changes
Jun 25, 2023
...agentcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationInfo.java
Outdated
Show resolved
Hide resolved
...agentcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationType.java
Outdated
Show resolved
Hide resolved
...agentcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationInfo.java
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1232 +/- ##
=============================================
+ Coverage 41.65% 41.77% +0.11%
- Complexity 3204 3226 +22
=============================================
Files 811 817 +6
Lines 17939 18029 +90
Branches 1952 1960 +8
=============================================
+ Hits 7473 7532 +59
- Misses 9530 9551 +21
- Partials 936 946 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
...agentcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationType.java
Outdated
Show resolved
Hide resolved
...m/huaweicloud/sermant/implement/service/dynamicconfig/zookeeper/ZooKeeperBufferedClient.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
develop
branch
2 times, most recently
from
June 27, 2023 12:46
7e40527
to
c9bbe81
Compare
...core-core/src/main/java/com/huaweicloud/sermant/core/notification/NettyNotificationType.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/huaweicloud/sermant/core/notification/SermantNotificationType.java
Outdated
Show resolved
Hide resolved
...ntcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationManager.java
Outdated
Show resolved
Hide resolved
...re-core/src/main/java/com/huaweicloud/sermant/core/notification/SermantNotificationType.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/huaweicloud/sermant/core/notification/ZookeeperNotificationType.java
Outdated
Show resolved
Hide resolved
...m/huaweicloud/sermant/implement/service/dynamicconfig/zookeeper/ZooKeeperBufferedClient.java
Outdated
Show resolved
Hide resolved
...ntcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationManager.java
Show resolved
Hide resolved
...ntcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationManager.java
Outdated
Show resolved
Hide resolved
...ntcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationManager.java
Outdated
Show resolved
Hide resolved
...m/huaweicloud/sermant/implement/service/dynamicconfig/zookeeper/ZooKeeperBufferedClient.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
develop
branch
2 times, most recently
from
June 28, 2023 10:08
1585a5b
to
be97e20
Compare
...ntcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationManager.java
Show resolved
Hide resolved
...tcore-core/src/main/java/com/huaweicloud/sermant/core/notification/NotificationListener.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Jun 29, 2023
...core-core/src/main/java/com/huaweicloud/sermant/core/notification/NettyNotificationType.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
previously approved these changes
Jun 29, 2023
lilai23
reviewed
Jun 29, 2023
...-core/src/main/java/com/huaweicloud/sermant/core/notification/ZookeeperNotificationType.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Jun 29, 2023
...mplement/src/main/java/com/huaweicloud/sermant/implement/service/send/netty/NettyClient.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
develop
branch
2 times, most recently
from
June 29, 2023 06:38
ed4e8ed
to
2b0aaa1
Compare
lilai23
approved these changes
Jun 29, 2023
luanwenfei-venus
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】#1231
【修改内容】
1、增加AgentCore事件通知
【用例描述】
1、已增加UT
【自测情况】
1、本地静态检查通过
2、自测通过
【影响范围】
1、对用户的使用存在影响,后续增加用户使用手册。