Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改动态配置UT失败问题 #1230

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jun 19, 2023

【修复issue】#1229

【修改内容】1、修改动态配置UT

【用例描述】
1、修改动态配置插件的UT实例化失败的问题
2、修改离群集成插件的UT出现统计数据遍历失败的情况。

【自测情况】1、本地自测通过

【影响范围】1、对用户的使用没有影响(

@hanbingleixue hanbingleixue added kind/bug Something isn't working kind/unit-test Issues or PRs releated to sermant test labels Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (066c5b3) 41.65% compared to head (d91ed82) 41.69%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1230      +/-   ##
=============================================
+ Coverage      41.65%   41.69%   +0.03%     
- Complexity      3200     3204       +4     
=============================================
  Files            811      811              
  Lines          17927    17925       -2     
  Branches        1949     1949              
=============================================
+ Hits            7468     7473       +5     
+ Misses          9523     9516       -7     
  Partials         936      936              
Flag Coverage Δ
unittests 41.69% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lilai23 lilai23 self-requested a review June 19, 2023 06:58
@Sherlockhan Sherlockhan merged commit 6eb4abc into sermant-io:develop Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/unit-test Issues or PRs releated to sermant test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants