Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增springboot注册插件事件上报&支持stop方法中上报事件 #1224

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Jun 7, 2023

【修复issue】#1205

【修改内容】
(1)添加springboot注册插件的注册事件,移除注册事件和灰度配置事件的上报
(2)新增插件服务的stop方法中添加的事件上报
(3)添加插件服务启动事件的上报

【用例描述】
测试过程:
(1)启动backend
(2)启用springboot注册插件来启动服务,并开启事件上报
(3)发布灰度配置
(4)关闭服务
(5)观察backend事件的上报
测试结果:
image

【自测情况】1、本地静态检查通过;2、本地测试通过

【影响范围】无

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (178fb70) 41.66% compared to head (8d3dd40) 41.62%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1224      +/-   ##
=============================================
- Coverage      41.66%   41.62%   -0.04%     
  Complexity      3200     3200              
=============================================
  Files            811      811              
  Lines          17926    17940      +14     
  Branches        1948     1951       +3     
=============================================
  Hits            7468     7468              
- Misses          9522     9536      +14     
  Partials         936      936              
Flag Coverage Δ
unittests 41.62% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mant/core/plugin/service/PluginServiceManager.java 14.28% <0.00%> (-3.90%) ⬇️
...uaweicloud/sermant/core/service/ServiceConfig.java 0.00% <0.00%> (ø)
...aweicloud/sermant/core/service/ServiceManager.java 7.69% <0.00%> (-1.57%) ⬇️
...mant/router/common/event/RouterEventCollector.java 26.19% <0.00%> (ø)
...ant/router/common/event/RouterEventDefinition.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luanwenfei-venus luanwenfei-venus added area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement labels Jun 15, 2023
@luanwenfei-venus luanwenfei-venus changed the title 【enhancement】新增springboot注册插件事件上报&支持stop方法中上报事件 新增springboot注册插件事件上报&支持stop方法中上报事件 Jun 15, 2023
@Sherlockhan
Copy link
Collaborator

codecheck问题为“禁止捕捉Exception”,实际此处为服务启动处,实际逻辑需要捕捉所有异常,因此忽略此codecheck失败项

@Sherlockhan Sherlockhan merged commit 925b052 into sermant-io:develop Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants