Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【fix】修复springboot注册插件获取spring.application.name的bug #1204

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

provenceee
Copy link
Collaborator

【修复issue】 #1197
【修改内容】修改获取spring.application.name的拦截点,原拦截点获取spring.application.name时,environment未完成初始化,导致获取值不对
【用例描述】不涉及
【自测情况】本地静态检查已过
【影响范围】不涉及

@provenceee provenceee added kind/bug Something isn't working area/plugin Issues or PRs releated to sermant plugin service labels Apr 18, 2023
@provenceee provenceee self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ee8c296) 42.10% compared to head (6e5eca0) 42.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1204   +/-   ##
==========================================
  Coverage      42.10%   42.10%           
+ Complexity      3226     3225    -1     
==========================================
  Files            812      812           
  Lines          17941    17941           
  Branches        1949     1949           
==========================================
  Hits            7554     7554           
+ Misses          9439     9438    -1     
- Partials         948      949    +1     
Flag Coverage Δ
unittests 42.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@provenceee provenceee force-pushed the fix-springboot branch 2 times, most recently from e56496d to d061c1a Compare April 20, 2023 02:57
@luanwenfei-venus luanwenfei-venus merged commit a291527 into sermant-io:develop Apr 27, 2023
@provenceee provenceee deleted the fix-springboot branch August 2, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants