Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【fix】设置GatewayConfig默认的配置&修复配置为空的解析bug #1195

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Apr 14, 2023

【修复issue】#1193

【修改内容】
1、设置GatewayConfig默认的配置
2、修复配置为空的解析bug

【用例描述】1、本地配置配置文件时,int字段的value为空,可以正常解析

【自测情况】1、本地静态检查清理情况;2、本地自测通过

【影响范围】无

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 45.83% and project coverage change: -0.02 ⚠️

Comparison is base (e7a62d5) 42.11% compared to head (14b5e06) 42.09%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1195      +/-   ##
=============================================
- Coverage      42.11%   42.09%   -0.02%     
+ Complexity      3226     3224       -2     
=============================================
  Files            812      812              
  Lines          17936    17941       +5     
  Branches        1949     1949              
=============================================
- Hits            7554     7553       -1     
- Misses          9434     9439       +5     
- Partials         948      949       +1     
Flag Coverage Δ
unittests 42.09% <45.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ermant/core/service/send/config/GatewayConfig.java 0.00% <0.00%> (ø)
...oud/sermant/core/config/utils/ConfigValueUtil.java 28.05% <64.70%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luanwenfei-venus luanwenfei-venus merged commit 49b288e into sermant-io:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants