Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【bug】修改离群实例摘除插件的review意见 #1183

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

hanbingleixue
Copy link
Collaborator

【修复issue】#1117

【修改内容】1、修改review意见,增加动态配置

【用例描述】1、不需要,功能未发生改变

【自测情况】1、本地静态检查清理情况;2、自测通过

【影响范围】1、对用户的使用没有影响

@hanbingleixue hanbingleixue changed the title 修改review意见 【bug】修改review意见 Apr 9, 2023
@hanbingleixue hanbingleixue changed the title 【bug】修改review意见 【bug】修改离群实例摘除插件的review意见 Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.70 🎉

Comparison is base (53e844d) 41.47% compared to head (07a6a69) 42.17%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1183      +/-   ##
=============================================
+ Coverage      41.47%   42.17%   +0.70%     
- Complexity      3184     3226      +42     
=============================================
  Files            810      812       +2     
  Lines          17869    17917      +48     
  Branches        1946     1948       +2     
=============================================
+ Hits            7411     7557     +146     
+ Misses          9518     9413     -105     
- Partials         940      947       +7     
Flag Coverage Δ
unittests 42.17% <ø> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robotLJW robotLJW added kind/bug Something isn't working status/lgtm Indicates that a PR is ready to be merged. labels Apr 9, 2023
@robotLJW robotLJW added this to the v1.1.0 milestone Apr 9, 2023
@robotLJW robotLJW merged commit 8b866b4 into sermant-io:develop Apr 9, 2023
@hanbingleixue hanbingleixue deleted the reviewNew branch August 31, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants