Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【enhancement】http请求兼容非标准HttpMethod的实现(1.0.x) #1179

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Apr 6, 2023

【修复issue】#1177

【修改内容】使用httpclient时,可使用fluent-hc包等来发送HTTP请求,需兼容HttpEntityEnclosingRequest和HttpUriRequest的其他非标准实现,该PR兼容此类实现。
image

【用例描述】本地自测fluent-hc发送各http请求可以正常被重新构造

【自测情况】1、本地静态检查清理通过;2、本地自测通过

【影响范围】兼容使用fluent-hc等实现httpmethod的用户

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c68dd3b) 45.61% compared to head (81a0524) 45.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##              1.0.x    #1179   +/-   ##
=========================================
  Coverage     45.61%   45.61%           
  Complexity     2925     2925           
=========================================
  Files           676      676           
  Lines         14939    14939           
  Branches       1680     1680           
=========================================
  Hits           6814     6814           
  Misses         7270     7270           
  Partials        855      855           
Flag Coverage Δ
unittests 45.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

provenceee
provenceee previously approved these changes Apr 6, 2023
@robotLJW robotLJW added kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged. labels Apr 7, 2023
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW merged commit c62a261 into sermant-io:1.0.x Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants