Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【enhancement】将服务黑名单开关服务改为统一通过开关配置 #1165

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

luanwenfei-venus
Copy link
Collaborator

@luanwenfei-venus luanwenfei-venus commented Apr 1, 2023

【修复issue】#1164

【修改内容】1、修改了根据服务黑名单来判断是否开启服务的逻辑 2、删除了服务可见性服务维护的独立开关配置 3、heartbeat中netty初始化放入start方法

【用例描述】
【用例1】通过开关开启服务在Backend可以看到相关服务的开启事件
配置如下:
image
结果如下:
image
【用例1】通过开关关闭服务在Backend可以看到相关服务未开启
配置如下:
image
结果如下:
image

【自测情况】1、本地静态检查清理情况;2、本地测试已通过

【影响范围】1、需修改文档中针对服务开关配置的部分

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 1.69% and project coverage change: -0.05 ⚠️

Comparison is base (0d41407) 41.57% compared to head (de99f4a) 41.53%.

❗ Current head de99f4a differs from pull request most recent head 2d151c6. Consider uploading reports for the commit 2d151c6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1165      +/-   ##
=============================================
- Coverage      41.57%   41.53%   -0.05%     
  Complexity      3184     3184              
=============================================
  Files            810      810              
  Lines          17826    17844      +18     
  Branches        1938     1947       +9     
=============================================
  Hits            7411     7411              
- Misses          9475     9493      +18     
  Partials         940      940              
Flag Coverage Δ
unittests 41.53% <1.69%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eicloud/sermant/core/event/config/EventConfig.java 0.00% <ø> (ø)
.../sermant/core/plugin/agent/config/AgentConfig.java 0.00% <ø> (ø)
...uaweicloud/sermant/core/service/ServiceConfig.java 0.00% <0.00%> (ø)
...ermant/core/service/send/config/GatewayConfig.java 0.00% <0.00%> (ø)
...mant/implement/service/send/netty/NettyClient.java 1.33% <0.00%> (-0.04%) ⬇️
...plement/service/send/netty/NettyClientFactory.java 0.00% <0.00%> (ø)
...plement/service/send/netty/NettyGatewayClient.java 15.62% <0.00%> (ø)
...ment/service/visibility/VisibilityServiceImpl.java 0.00% <0.00%> (ø)
...aweicloud/sermant/core/service/ServiceManager.java 9.25% <33.33%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luanwenfei-venus luanwenfei-venus force-pushed the develop branch 2 times, most recently from 3d5bbec to 5b16828 Compare April 1, 2023 09:33
@luanwenfei-venus luanwenfei-venus force-pushed the develop branch 4 times, most recently from 96d59bc to 17b5247 Compare April 3, 2023 09:28
@robotLJW robotLJW added kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged. labels Apr 3, 2023
@robotLJW robotLJW added this to the v1.1.0 milestone Apr 3, 2023
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW merged commit 53e844d into sermant-io:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants