-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【enhancement】将服务黑名单开关服务改为统一通过开关配置 #1165
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1165 +/- ##
=============================================
- Coverage 41.57% 41.53% -0.05%
Complexity 3184 3184
=============================================
Files 810 810
Lines 17826 17844 +18
Branches 1938 1947 +9
=============================================
Hits 7411 7411
- Misses 9475 9493 +18
Partials 940 940
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
3d5bbec
to
5b16828
Compare
...sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/service/ServiceConfig.java
Show resolved
Hide resolved
96d59bc
to
17b5247
Compare
17b5247
to
2d151c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
【修复issue】#1164
【修改内容】1、修改了根据服务黑名单来判断是否开启服务的逻辑 2、删除了服务可见性服务维护的独立开关配置 3、heartbeat中netty初始化放入start方法
【用例描述】
【用例1】通过开关开启服务在Backend可以看到相关服务的开启事件
配置如下:
结果如下:
【用例1】通过开关关闭服务在Backend可以看到相关服务未开启
配置如下:
结果如下:
【自测情况】1、本地静态检查清理情况;2、本地测试已通过
【影响范围】1、需修改文档中针对服务开关配置的部分