Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【fix】修复优雅上下线ut #1130

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

provenceee
Copy link
Collaborator

【修复issue】 #1115

【修改内容】修复优雅上下线ut

【用例描述】SpringZuulResponseInterceptorTest失败

【自测情况】SpringZuulResponseInterceptorTest成功

【影响范围】不涉及

@provenceee provenceee added kind/bug Something isn't working area/plugin Issues or PRs releated to sermant plugin service kind/unit-test Issues or PRs releated to sermant test labels Mar 20, 2023
@provenceee provenceee self-assigned this Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 85.18% and project coverage change: +0.02 🎉

Comparison is base (9faa151) 43.53% compared to head (e88aac3) 43.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1130      +/-   ##
=============================================
+ Coverage      43.53%   43.55%   +0.02%     
- Complexity      3025     3027       +2     
=============================================
  Files            748      748              
  Lines          16064    16067       +3     
  Branches        1742     1740       -2     
=============================================
+ Hits            6993     6998       +5     
+ Misses          8198     8197       -1     
+ Partials         873      872       -1     
Flag Coverage Δ
unittests 43.55% <85.18%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ei/registry/config/grace/GraceShutDownManager.java 68.08% <50.00%> (-1.69%) ⬇️
...huawei/registry/service/utils/HttpClientUtils.java 85.71% <60.00%> (-4.29%) ⬇️
...rs/SpringLoadbalancerFeignResponseInterceptor.java 77.27% <100.00%> (+5.27%) ⬆️
...ngLoadbalancerRestTemplateResponseInterceptor.java 83.33% <100.00%> (+8.33%) ⬆️
...ce/interceptors/SpringZuulResponseInterceptor.java 82.35% <100.00%> (+8.66%) ⬆️
...egistry/inject/grace/SpringRequestInterceptor.java 78.57% <100.00%> (+1.64%) ⬆️
...huawei/registry/service/impl/GraceServiceImpl.java 75.00% <100.00%> (+1.92%) ⬆️
...wei/registry/service/server/NotifyHttpHandler.java 80.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robotLJW robotLJW added this to the v1.1.0 milestone Mar 20, 2023
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW merged commit b3f86dd into sermant-io:develop Mar 20, 2023
@provenceee provenceee deleted the fix-ut branch March 25, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/bug Something isn't working kind/unit-test Issues or PRs releated to sermant test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants