【fix】修复路由规则配置不正确的情况下，有可能出现的npe #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provenceee
added
kind/bug
Codecov ReportBase: 45.65% // Head: 45.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1080 +/- ##
=============================================
+ Coverage 45.65% 45.67% +0.02%
- Complexity 2989 3028 +39
=============================================
Files 689 700 +11
Lines 15163 15357 +194
Branches 1698 1702 +4
=============================================
+ Hits 6923 7015 +92
- Misses 7377 7470 +93
- Partials 863 872 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lilai23
previously approved these changes
Jan 30, 2023
hanbingleixue
previously approved these changes
Jan 30, 2023
provenceee
dismissed stale reviews from hanbingleixue and lilai23
via
0077af9
hanbingleixue
previously approved these changes
Jan 30, 2023
robotLJW
reviewed
Jan 30, 2023
...outer-config-common/src/main/java/com/huaweicloud/sermant/router/config/utils/RuleUtils.java
Show resolved
Hide resolved
robotLJW
reviewed
Jan 30, 2023
...service/src/main/java/com/huaweicloud/sermant/router/config/handler/RouterConfigHandler.java
Show resolved
Hide resolved
robotLJW
reviewed
Jan 30, 2023
...ervice/src/main/java/com/huaweicloud/sermant/router/config/handler/ServiceConfigHandler.java
Show resolved
Hide resolved
robotLJW
reviewed
Jan 30, 2023
...outer-config-common/src/main/java/com/huaweicloud/sermant/router/config/utils/RuleUtils.java
Outdated
Show resolved
Hide resolved
|
@hanbingleixue 这个PR记得的合入1.0.x 中bugfix |
xuezechao1
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【修复issue】 #1079
【修改内容】解析路由规则后，移除不合法的规则
【用例描述】不需要修改用例
【自测情况】1、新增非法路由规则，2、解析规则不再报空指针
【影响范围】1、对用户的使用没有影响