Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Enhancement】add visibility plugin #1075

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

hanbingleixue
Copy link
Collaborator

【修复issue】#1074

【修改内容】增加服务可见性功能插件

【用例描述】1、增加服务可见性采集功能用例

【自测情况】1、本地静态检查清理通过;2、自测通过;

【影响范围】1、已增加相关使用文档

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 45.65% // Head: 45.31% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (2fa706a) compared to base (315f7d0).
Patch coverage: 23.52% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1075      +/-   ##
=============================================
- Coverage      45.65%   45.31%   -0.35%     
- Complexity      2989     3012      +23     
=============================================
  Files            689      700      +11     
  Lines          15163    15348     +185     
  Branches        1698     1701       +3     
=============================================
+ Hits            6923     6955      +32     
- Misses          7377     7529     +152     
- Partials         863      864       +1     
Flag Coverage Δ
unittests 45.31% <23.52%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/core/service/visibility/common/OperateType.java 0.00% <0.00%> (ø)
...ice/visibility/config/VisibilityServiceConfig.java 0.00% <0.00%> (ø)
...mant/core/service/visibility/entity/ParamInfo.java 0.00% <0.00%> (ø)
...ant/core/service/visibility/entity/ServerInfo.java 0.00% <0.00%> (ø)
...om/huaweicloud/sermant/core/utils/StringUtils.java 16.27% <0.00%> (-0.39%) ⬇️
...ud/sermant/implement/service/send/NettyClient.java 1.88% <0.00%> (-0.04%) ⬇️
...ment/service/visibility/VisibilityServiceImpl.java 0.00% <0.00%> (ø)
...ant/core/service/visibility/entity/MethodInfo.java 30.00% <30.00%> (ø)
.../core/service/visibility/entity/Consanguinity.java 46.15% <46.15%> (ø)
...rmant/core/service/visibility/entity/Contract.java 56.25% <56.25%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanbingleixue hanbingleixue force-pushed the develop branch 9 times, most recently from 246ef69 to 4e886b2 Compare January 9, 2023 06:39
@robotLJW
Copy link
Collaborator

插件的测试用例呢?plugin下面的test以及service下面的测试用例呢?

@hanbingleixue hanbingleixue dismissed stale reviews from xuezechao1 and provenceee via d99fcfa January 14, 2023 10:26
@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from d99fcfa to abcd708 Compare January 14, 2023 10:29
@hanbingleixue
Copy link
Collaborator Author

插件的测试用例呢?plugin下面的test以及service下面的测试用例呢?

缓存类的test用例已增加。其他服务由于功能依赖消息发送。无法测试。

Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW added the status/lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@robotLJW robotLJW merged commit 20aa397 into sermant-io:develop Jan 16, 2023
@robotLJW robotLJW added this to the v1.1.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants