Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【question】Nacos注册实例增加parameters作为标签路由内容 #1063

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

chengyouling
Copy link
Collaborator

【修复issue】#1062

【修改内容】注册nacos实例信息增加ServiceMeta中的parameters

【用例描述】不需要修改用例。
【自测情况】1、本地静态检查清理情况;

【影响范围】1、dubbo注册Nacos实例标签路由能力

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 45.59% // Head: 45.56% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (35857b4) compared to base (f093471).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1063      +/-   ##
=============================================
- Coverage      45.59%   45.56%   -0.03%     
  Complexity      2916     2916              
=============================================
  Files            673      673              
  Lines          14860    14863       +3     
  Branches        1671     1673       +2     
=============================================
- Hits            6776     6773       -3     
- Misses          7239     7243       +4     
- Partials         845      847       +2     
Flag Coverage Δ
unittests 45.56% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bbo/registry/service/NacosRegistryServiceImpl.java 64.81% <0.00%> (-0.61%) ⬇️
...mplement/service/tracing/sender/TracingSender.java 63.49% <0.00%> (-4.77%) ⬇️
...try/interceptors/DynamicServerListInterceptor.java 58.06% <0.00%> (-1.94%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robotLJW robotLJW added this to the v1.0.0 milestone Dec 24, 2022
@robotLJW robotLJW added kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged. labels Dec 24, 2022
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW merged commit eb7f83c into sermant-io:develop Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or PRs releated to sermant enhancement status/lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants