-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #1037, 容器部署场景下,希望能通过annotation的方式配置治理所需的kv属性或者标签 #1061
Conversation
Codecov ReportBase: 45.55% // Head: 45.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1061 +/- ##
==========================================
Coverage 45.55% 45.55%
Complexity 2920 2920
==========================================
Files 673 673
Lines 14921 14921
Branches 1680 1680
==========================================
Hits 6798 6798
Misses 7271 7271
Partials 852 852
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...or/src/main/java/com/huaweicloud/sermant/injection/controller/SermantInjectorController.java
Outdated
Show resolved
Hide resolved
checkstyle 静态检查需要再检查下 |
这个PR我先回退下。 下周一开会我们讨论下这个需求。 |
commit 信息合成一个 |
...or/src/main/java/com/huaweicloud/sermant/injection/controller/SermantInjectorController.java
Outdated
Show resolved
Hide resolved
这边自测情况应该需要修改一下,应该是annotation属性 |
...or/src/main/java/com/huaweicloud/sermant/injection/controller/SermantInjectorController.java
Outdated
Show resolved
Hide resolved
...or/src/main/java/com/huaweicloud/sermant/injection/controller/SermantInjectorController.java
Outdated
Show resolved
Hide resolved
...or/src/main/java/com/huaweicloud/sermant/injection/controller/SermantInjectorController.java
Show resolved
Hide resolved
...rc/test/java/com/huaweicloud/sermant/injection/controller/SermantInjectorControllerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
【修复issue】 #1037
【feature】容器部署场景下,希望能通过annotation的方式配置治理所需的kv属性或者标签
【修改内容】
增加Controller通过识别对应annotation属性,来增加对env的支持
【用例描述】是否需要修改用例?原因?/ 不增加用例的原因?
不需要。已在单元测试中覆盖。
【自测情况】
在测试环境中增加了label属性,根据测试,发现可以将结果注入到对应环境变量中。
【影响范围】
需要增加API文档,说明该功能。