Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #1037, 容器部署场景下,希望能通过annotation的方式配置治理所需的kv属性或者标签 #1061

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

yangyshdan
Copy link
Collaborator

@yangyshdan yangyshdan commented Dec 23, 2022

【修复issue】 #1037
【feature】容器部署场景下,希望能通过annotation的方式配置治理所需的kv属性或者标签

【修改内容】
增加Controller通过识别对应annotation属性,来增加对env的支持

【用例描述】是否需要修改用例?原因?/ 不增加用例的原因?
不需要。已在单元测试中覆盖。

【自测情况】
在测试环境中增加了label属性,根据测试,发现可以将结果注入到对应环境变量中。

【影响范围】
需要增加API文档,说明该功能。

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 45.55% // Head: 45.55% // No change to project coverage 👍

Coverage data is based on head (03a53b5) compared to base (8bd9745).
Patch has no changes to coverable lines.

❗ Current head 03a53b5 differs from pull request most recent head 2fd82fb. Consider uploading reports for the commit 2fd82fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1061   +/-   ##
==========================================
  Coverage      45.55%   45.55%           
  Complexity      2920     2920           
==========================================
  Files            673      673           
  Lines          14921    14921           
  Branches        1680     1680           
==========================================
  Hits            6798     6798           
  Misses          7271     7271           
  Partials         852      852           
Flag Coverage Δ
unittests 45.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lilai23
Copy link
Collaborator

lilai23 commented Dec 24, 2022

checkstyle 静态检查需要再检查下

@yangyshdan
Copy link
Collaborator Author

这个PR我先回退下。 下周一开会我们讨论下这个需求。

@yangyshdan yangyshdan requested a review from lilai23 December 26, 2022 01:50
@robotLJW
Copy link
Collaborator

commit 信息合成一个

@robotLJW
Copy link
Collaborator

robotLJW commented Dec 26, 2022

【修复issue】 #1037 【feature】容器部署场景下,希望能通过annotation的方式配置治理所需的kv属性或者标签

【修改内容】 增加Controller通过识别对应label属性,来增加对env的支持

【用例描述】是否需要修改用例?原因?/ 不增加用例的原因? 不需要。已在单元测试中覆盖。

【自测情况】 在测试环境中增加了label属性,根据测试,发现可以将结果注入到对应环境变量中。

【影响范围】 需要增加API文档,说明该功能。

这边自测情况应该需要修改一下,应该是annotation属性

provenceee
provenceee previously approved these changes Dec 27, 2022
@robotLJW robotLJW added the kind/enhancement Issues or PRs releated to sermant enhancement label Dec 27, 2022
@robotLJW robotLJW added this to the v1.0.0 milestone Dec 27, 2022
Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW merged commit efd9898 into sermant-io:develop Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants