Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【enhance】Optimize plugins #1054

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Conversation

provenceee
Copy link
Collaborator

What type of PR is this?

/enhance

Which issue(s) this PR fixes:

Fixes #1053

Use case description: n/a

Does this PR introduce a user-facing change?

No

Additional documentation e.g., usage docs, etc.:

No

@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Dec 20, 2022
@provenceee provenceee self-assigned this Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 46.00% // Head: 45.56% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (c840cb3) compared to base (df1666f).
Patch coverage: 84.88% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1054      +/-   ##
=============================================
- Coverage      46.00%   45.56%   -0.45%     
+ Complexity      2916     2907       -9     
=============================================
  Files            669      669              
  Lines          14799    14837      +38     
  Branches        1661     1667       +6     
=============================================
- Hits            6809     6761      -48     
- Misses          7133     7228      +95     
+ Partials         857      848       -9     
Flag Coverage Δ
unittests 45.56% <84.88%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/dubbo/interceptor/ContextFilterInterceptor.java 84.21% <33.33%> (-9.91%) ⬇️
...er/spring/interceptor/RouteHandlerInterceptor.java 73.91% <33.33%> (+73.91%) ⬆️
...pring/interceptor/BaseLoadBalancerInterceptor.java 80.76% <50.00%> (+0.37%) ⬆️
...r/spring/interceptor/HystrixActionInterceptor.java 54.54% <66.66%> (-1.02%) ⬇️
...er/dubbo/service/AbstractDirectoryServiceImpl.java 88.88% <75.00%> (-1.92%) ⬇️
...m/huaweicloud/sermant/core/utils/ReflectUtils.java 69.87% <81.25%> (-0.54%) ⬇️
...eicloud/sermant/router/config/utils/RuleUtils.java 56.81% <81.81%> (+1.53%) ⬆️
.../flowcontrol/res4j/chain/AbstractChainHandler.java 100.00% <100.00%> (ø)
...wei/flowcontrol/res4j/chain/HandlerChainEntry.java 100.00% <100.00%> (ø)
.../sermant/router/dubbo/utils/DubboReflectUtils.java 91.30% <100.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@robotLJW robotLJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robotLJW robotLJW added this to the v1.0.0 milestone Dec 24, 2022
@robotLJW robotLJW merged commit 92b84e3 into sermant-io:develop Dec 24, 2022
@provenceee provenceee deleted the optimization branch March 25, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【enhance】Optimize plugins
4 participants