New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validation): import json directly to avoid issues with bundlers #170

Open

sudo-alexslater wants to merge 2 commits into seriousme:master from sudo-alexslater:fix/direct-import-for-bundlers

sudo-alexslater commented Nov 14, 2024

Fixes seriousme/fastify-openapi-glue#620

Alex Slater added 2 commits

November 14, 2024 15:35


          fix(validation): import json directly to avoid issues with bundlers

540d685


          fix(tests): get coverage of error line

fdd26ba

Owner

seriousme commented Nov 19, 2024

Hi,

the linter errors can probably be fixed by running npm run test as this will automatically run npm run format.

Another problem is that import assert { type: "json"} has been removed from node 22 and later, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import
Its succesor is import with { type: "json"} however that might not be available on all LTS versions yet.

Kind regards,
Hans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet