2.3.0 Release #41
Merged
2.3.0 Release #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nblumhardt
commented
Feb 16, 2020
•
nblumhardt
commented
- Simplify the constructors for PeriodicBatchingSink and BoundedConcurrentQueue. #30, Allow NON_BOUNDED value to be used as constructor parameter #34, Refactor to support use as a wrapper sink; add sink options #39, Set defaults when using PeriodicBatchingSinkOptions #40 - improve factoring, allow implementations to override "eager-first-event" behavior (@kimbirkelund, @oliverholliday, @nblumhardt)
…vior of the queue.
Allow NON_BOUNDED value to be used as constructor parameter
Simplify the constructors for PeriodicBatchingSink and BoundedConcurrentQueue.
…ctor to support usage as a wrapper class; fixes #38
Refactor to support use as a wrapper sink; add sink options
Set defaults when using PeriodicBatchingSinkOptions
julealgon
approved these changes
Feb 17, 2020
| { | ||
| const int NON_BOUNDED = -1; | ||
| public const int NonBounded = -1; |
There was a problem hiding this comment.
Are we tracking to rename this to Unbounded on the next release? NonBounded is not proper English.
There was a problem hiding this comment.
Can't believe I didn't catch that when writing it.
There was a problem hiding this comment.
:-) I fixed the XML parameter docs but forgot about this; I'll send one though (though it's not public API surface)
|
Eagerly awaiting for this one! Do we have an ETA? I assume the package will be published as soon as this is merged? |
|
Hi @julealgon - yes, this will be published as soon as it's merged. Ideally we'd get some more feedback on the new APIs before setting them in stone, but if we don't hear any more this week I'll hit the button 👍 |
NonBounded -> Unbounded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.