Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for net framework, removed ide settings and updated readm… #160

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Added tests for net framework, removed ide settings and updated readm… #160

merged 5 commits into from
Sep 18, 2024

Conversation

alsi-lawr
Copy link
Contributor

@alsi-lawr alsi-lawr commented Sep 14, 2024 •
edited
Loading

Modifications

  • I had to make some minor changes to the unit tests to ensure they compile and run for .NET framework
  • I've added a conditional step to set the Activity.DefaultIdFormat for tests run against .NET framework
  • I've removed the IDE configuration left in the repo
  • I've added a section to the README explaining how to set up activity traces for .NET framework

Resolved Issues

@nblumhardt nblumhardt merged commit 7b0cfe5 into serilog:dev Sep 18, 2024
1 check passed
@nblumhardt
Copy link
Member

Awesome, thank you (sorry about the delay, traveling for a few days! 👋)

@nblumhardt nblumhardt mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alsi-lawr @nblumhardt