Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding netcoreapp2.0 target #80

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Adding netcoreapp2.0 target #80

merged 1 commit into from
Jan 24, 2020

Conversation

megakid
Copy link
Contributor

@megakid megakid commented Jan 12, 2020

What issue does this PR address?
#78

Does this PR introduce a breaking change?
None that I know of.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:
N/A

@nblumhardt
Copy link
Member

Thanks for this; since the sink supports netstandard2.0, is there any benefit in supporting netcoreapp2.0 as well? Cheers!

@megakid
Copy link
Contributor Author

megakid commented Jan 15, 2020

I believe the value is explained here: #78

@nblumhardt nblumhardt merged commit eafe7d5 into serilog:dev Jan 24, 2020
@nblumhardt nblumhardt mentioned this pull request Jan 24, 2020
Closed
2 tasks
@nblumhardt nblumhardt mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megakid @nblumhardt