-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to lts 31 #205
Update to lts 31 #205
Conversation
…nce it reached End Of Life
…more explicty/readable test assertions
…that it install the SDK from global.json
@@ -14,7 +14,7 @@ public class ConfigurationReaderTests | |||
public ConfigurationReaderTests() | |||
{ | |||
_configurationReader = new ConfigurationReader( | |||
JsonStringConfigSource.LoadSection(@"{ 'Serilog': { } }", "Serilog"), | |||
JsonStringConfigSource.LoadSection(@"{ ""Serilog"": { } }", "Serilog"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be helpful.
And then
public override void Load()
{
Load(StringToStream(_json.ToValidJson()));
}
Still waiting for merge :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did not saw that PR ;)
Also the double quote seems fine for all TFM, do we want to have different JSON delimiter since one works for all ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My interest was to keep the number of changes in PR to a minimum. I achieved this with a few lines of code instead of a lot of refactoring. As a result, the tests work on both platforms. In addition, you will simply stop testing a single quote syntax. This is degradation of the test coverage.
This PR follow the logic of both :
serilog/serilog-aspnetcore#165
serilog/serilog-extensions-hosting#17
What this PR change :
global.json
netcoreapp3.1
as aTargetFramework
(Not the best way of resolution but it's still better than doing nothing)powershell
scriptPackageIcon
asPackageIconUrl
is being deprecatedSerilog
Thoughts :
As said in this PR :
serilog/serilog-extensions-hosting#17
Side note
I have no idea who use directly this dependency, but should it be concidered to just drop
net46x
andnet45
?The same way
Major
version and pinning works, and also sincenet472/net48
are supposed to benetstandard2.0
they should show be able to resolves2.1
dependencies