-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ValueTuple<string, object?>
as state of scope.
#232
Conversation
Thanks @jimbojim1997! This looks good, even if the need for the second tuple member to be 8.0.0 is going out in the next ~24 hours so it's too late for this change to make that release, unfortunately. We'll be able to ship it shortly afterwards, though. |
@@ -0,0 +1,100 @@ | |||
// Copyright (c) .NET Foundation. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .NET Foundation copyright header intended here, and in the other test file below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what it needs to be so just copied it from another file.
I've had another look and there's a mix of files with this header, Copyright [year] Serilog Contributors
, and no header. What should I change this and the other file to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard header as per serilog core without a year in all source files
Optional in test files
(I've yet to do the PR to make it completely consistent in core)
serilog/serilog#1969 (comment)
I think the checks for Sorry about the long delay @jimbojim1997, thanks for this! |
Change for issue #186.
When calling
ILogger.BeginScope<TState>(TState state)
TState
can now be aValueTuple<string, object?>
,Item1
is used as the property name andItem2
is used as the property value.