Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added pushing properties to Readme #217

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Conversation

svrooij
Copy link
Contributor

@svrooij svrooij commented Oct 22, 2020

Fixed #212

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ivan Maximov <[email protected]>
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicky suggestions from me, looks good!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@svrooij
Copy link
Contributor Author

svrooij commented Oct 22, 2020

I’m ok with squashing this PR, because it looks like a mess right now. Four commits to change one alinea in the readme. Just squash and add this to the commit message:

Co-authored-by: Stephan van Rooij <[email protected]>

@nblumhardt nblumhardt merged commit 2857be8 into serilog:dev Oct 26, 2020
@nblumhardt
Copy link
Member

Thanks 👍

@svrooij
Copy link
Contributor Author

svrooij commented Oct 26, 2020

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Pushing properties to logevents
3 participants