Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Condition=" '$(OS)' != 'Windows_NT' " to PublicSign attribute #112

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Conversation

BrettJaner
Copy link
Contributor

Adding Condition=" '$(OS)' != 'Windows_NT' " to PublicSign attribute in Serilog.Sinks.Splunk.csproj to solve issue #76. When the PublicSign attribute is removed, the assembly is fully and properly signed.
Conditionally applying this attribute based on OS aligns with what the Serilog core library and other sinks are doing.

@BrettJaner
Copy link
Contributor Author

Just realized the build runs on an Ubuntu image, so you'd think the <PublicSign> would be applied. I checked the Serilog core library and it also builds on Ubuntu image. Now I'm puzzled how this would work.

@merbla
Copy link
Contributor

merbla commented Jun 16, 2019

@BrettJaner the builds run on Linux only for testing. The package pushed to NuGet comes from the Windows build.

Lets try this PR and check the dev packages.

@merbla merbla merged commit e8f8829 into serilog-contrib:dev Jun 16, 2019
@BrettJaner
Copy link
Contributor Author

Good deal, checked the package "v3.2.0-dev-00252" and it looks good! Probably should have incremented the minor version number with the pull request.

@merbla
Copy link
Contributor

merbla commented Jun 17, 2019

Bumped the version in #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants