Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Fix HasProperty when settings is a Dictionary #358

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

Evolva
Copy link
Contributor

@Evolva Evolva commented Sep 16, 2020

What issue does this PR address?
#357

Does this PR introduce a breaking change?
No, ExpandoObject is already an IDictionary<string, object>

@orjan
Copy link
Contributor

orjan commented Sep 16, 2020

Looks great!
Also, you're not alone, there are a couple of pull requests that's trying to addressing this issue:

@mivano mivano merged commit 9fe222c into serilog-contrib:dev Sep 16, 2020
@mivano
Copy link
Contributor

mivano commented Sep 16, 2020

Thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants