This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
ExceptionAsObjectJsonFormatter add renderMessageTemplate param #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorads
reviewed
Jan 9, 2020
| @@ -42,15 +42,18 @@ public class ExceptionAsObjectJsonFormatter : ElasticsearchJsonFormatter | |||
| /// <param name="formatProvider">Supplies culture-specific formatting information, or null.</param> | |||
| /// <param name="serializer">Inject a serializer to force objects to be serialized over being ToString()</param> | |||
| /// <param name="inlineFields">When set to true values will be written at the root of the json document</param> | |||
| /// /// <param name="renderMessageTemplate">If true, the message template will be rendered and written to the output as a | |||
There was a problem hiding this comment.
Is the double set of slashes /// /// deliberate?
There was a problem hiding this comment.
No copied from base object, will remove it.
|
Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing parameter for the ExceptionAsObjectJsonFormatter.
Don't want to render MessageTemplate.