This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Fixed two issues regarding BufferCleanPayload #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed a logical test issue that made the code to not go through the cleanup path when errors happened and a issue with the error message where a ToString was called on a dictionary resulting in the type name instead of the actual error message. I refrained from adding the detailed errors provided by elastic, because they can be many and ridiculously detailed
|
Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a logical test issue that made the code to not go through the
cleanup path when errors happened and a issue with the error message
where a ToString was called on a dictionary resulting in the type name
instead of the actual error message. I refrained from adding the
detailed errors provided by elastic, because they can be many and
ridiculously detailed
What issue does this PR address?
An issue with BufferCleanPayload #294
Does this PR introduce a breaking change?
Not really, but since it may start to execute code paths not previously executed it could cause peoples bugs to surface
Please check if the PR fulfills these requirements
Other information: