Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

for ES v6 use "index_patterns" instead of "template" field #207

Merged
merged 1 commit into from Dec 27, 2018
Merged

for ES v6 use "index_patterns" instead of "template" field #207

merged 1 commit into from Dec 27, 2018

Conversation

CaringDev
Copy link
Contributor

@CaringDev CaringDev commented Dec 27, 2018

What issue does this PR address?
fixes #206

Does this PR introduce a breaking change?
afaict NO

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:
This only fixes the error, a follow-up deprecation warning #! Deprecation: [_default_] mapping is deprecated since it is not useful anymore now that indexes cannot have more than one type is not addressed.

@mivano mivano merged commit ae63137 into serilog-contrib:dev Dec 27, 2018
@mivano
Copy link
Contributor

mivano commented Dec 27, 2018

Thanks for the PR!

@CaringDev CaringDev deleted the ES6_Template branch December 28, 2018 17:05
@CaringDev
Copy link
Contributor Author

Thanks for the quick merge. I can confirm that 6.5.0-alpha0043 does create the v6 template successfully.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES6 template syntax
2 participants