-
Notifications
You must be signed in to change notification settings - Fork 197
Get rid of 'deprecated' warnings in Elastic 5.6.2 #142
Conversation
Our Elastic 5.6.2 logs are flooded with below errors: The [string] field is deprecated, please use [text] or [keyword] [omit_norms] is deprecated, please use [norms] instead with the opposite boolean value Updated the schema following https://www.elastic.co/blog/strings-are-dead-long-live-strings
Looking forward to this, we are seeing the same |
When reading the issues, it seems in ES 6 the deprecation turned into removal, so this PR might fix ES 6 support too :) |
LGTM - but I'm no expert here :) Changes are similar to what I did to patch up the same set of issues for me (see code I provided in comments in issue #129). However, I didn't know about One thing I noticed is that this is just a change to mappings. Since newest ElasticSearch changed the schema (like 'index' is now true/false), then IMHO applying this will break support for lower versions of ElasticSearch. That may be OK, but then, at least one person was concerned some time ago |
I'll have a go at creating some kind of template provider, that can be set from the options ,something like pre-version5, version5, version6. |
Awesome! Looking forward to get this merged! // @mivano |
Thanks for the all the work. I will have a look soon.
Op do 11 jan. 2018 om 13:44 schreef David Cumps <[email protected]>
… Awesome! Looking forward to get this merged! // @mivano
<https://github.com/mivano>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAozdy5RvbEuW_A8OwEpytGLF7SpHLibks5tJgIVgaJpZM4RUaTA>
.
|
Great addition and thanks for the backward capability option! |
Awesome! |
Our Elastic 5.6.2 logs are flooded with below errors:
The [string] field is deprecated, please use [text] or [keyword]
[omit_norms] is deprecated, please use [norms] instead with the opposite boolean value
Updated the schema following https://www.elastic.co/blog/strings-are-dead-long-live-strings