option to set number of days of logfiles to keep #202

pierresetteskog · 2018-12-11T13:00:59Z

A few questions before you begin:

Is this an issue related to the Serilog core project or one of the sinks or
community projects.
This issue list is intended for Serilog Elasticsearch Sink issues. If this issue relates to another sink or to the code project,
please log on the related repository. Please use Gitter chat and Stack Overflow for discussions and questons.

Does this issue relate to a new feature or an existing bug?

Bug
New Feature

What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package.

What is the target framework and operating system? See target frameworks & net standard matrix.

Please describe the current behavior?
Old log files needs to be removed

Please describe the expected behavior?
in DurableElasticSearchSink.cs i expect an new option options.BufferFileRetainedCountLimit for how many days to keep the files, todays value is null.
Let me know if I should make a PR even if RollingFileSink is deprecated for FilelSink
_sink = new RollingFileSink(
options.BufferBaseFilename + FileNameSuffix,
_state.DurableFormatter,
options.BufferFileSizeLimitBytes,
options.BufferFileRetainedCountLimit);

If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem

option to set number of days of logfiles to keep serilog-contrib#202

* added BufferFileCountLimit to limit number of files option to set number of days of logfiles to keep #202 * init * Added example and fixes for persistant logging mosly code from https://github.com/serilog/serilog-sinks-seq * added BufferCleanPayload * dont force inheritance the timer start in base class is ca 5sec and will not start before inheritade base class is finished * renamed to Elasticsearch and added documentation in Readme and chenges * rename

mivano · 2019-03-23T09:34:50Z

Is this still an active issue or already fixed by the latest changes?

pierresetteskog pushed a commit to tacdisecomm/serilog-sinks-elasticsearch that referenced this issue Dec 14, 2018

added BufferFileCountLimit to limit number of files

b04acd0

option to set number of days of logfiles to keep serilog-contrib#202

pierresetteskog mentioned this issue Dec 14, 2018

added BufferFileCountLimit to limit number of files #204

Closed

2 tasks

mivano closed this as completed Mar 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

option to set number of days of logfiles to keep #202

option to set number of days of logfiles to keep #202

pierresetteskog commented Dec 11, 2018 •

edited

Loading

mivano commented Mar 23, 2019

option to set number of days of logfiles to keep #202

option to set number of days of logfiles to keep #202

Comments

pierresetteskog commented Dec 11, 2018 • edited Loading

mivano commented Mar 23, 2019

pierresetteskog commented Dec 11, 2018 •

edited

Loading