Add loopback test example #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Adds a new example with support for running loopback tests on a port and printing some timing statistics. Loopback test supports running in split or standard serial port modes, and specifiying the data and iterations of test to perform. Signed-off-by: mlsvrts <[email protected]>
mlsvrts
force-pushed
the
add_loopback_test
branch
from
c103ee0
to
f8c0bda
Compare
jessebraham
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Thank you for the PR, sorry for the delay in getting to this!
It looks good to me overall, however in its current state we get a panic when running due to both baudrate and bytes using -b as their short flag; removing short from one of these options gets the example to a working state.
Could you please just make that one fix (I removed short from --bytes but it probably doesn't matter too much)? After that we can get this merged.
Supporting '-b' for both 'bytes' and 'baudrate' could cause a collision, this update prevents the issue. Signed-off-by: mlsvrts <[email protected]>
Done! |
sirhcel
pushed a commit
to sirhcel/serialport-rs
that referenced
this pull request
May 10, 2023
* Add a loopback test example Adds a new example with support for running loopback tests on a port and printing some timing statistics. Loopback test supports running in split or standard serial port modes, and specifiying the data and iterations of test to perform. Signed-off-by: mlsvrts <[email protected]> * Remove 'short' from loopback test 'bytes' argument. Supporting '-b' for both 'bytes' and 'baudrate' could cause a collision, this update prevents the issue. Signed-off-by: mlsvrts <[email protected]> Signed-off-by: mlsvrts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example performs a loopback test using real hardware ports
Additionally, some data will be collected and logged during the test to provide some
rudimentary benchmarking information. When 'split-port' is specified, the serial port will be split into two channels that read/write "simultaneously" from multiple threads.
You can also provide the length (in bytes) of data to test with, and the number of iterations to perform or a list of raw bytes to transmit.
To run this example:
cargo run --example loopback /dev/ttyUSB0cargo run --example loopback /dev/ttyUSB0 --split-portcargo run --example loopback /dev/ttyUSB0 -i 100 -l 32 -b 9600cargo run --example loopback /dev/ttyUSB8 --bytes 222,173,190,239