Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenBSD compilation issue caused by disabled ErrorKind "use" #68

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

n1000
Copy link
Contributor

@n1000 n1000 commented Nov 6, 2022

Compilation error seen in this block:

        /// Enumerating serial ports on this platform is not supported
        pub fn available_ports() -> Result<Vec<SerialPortInfo>> {
            Err(Error::new(
                ErrorKind::Unknown,
                "Not implemented for this OS",
            ))
        }

@sirhcel
Copy link
Contributor

sirhcel commented Nov 30, 2022

Thank you very much for finding this issue and your contribution!

sirhcel added a commit to n1000/serialport-rs that referenced this pull request Nov 30, 2022
This was a target we missed out after migrating to GitHub. See PR serialport#68
and issue serialport#71.
@sirhcel
Copy link
Contributor

sirhcel commented Nov 30, 2022

Thank you very much for your contribution! And please excuse our sluggish response time.

The fix builds with the existing targets and I will try to get a CI build for OpenBSD back.

@sirhcel
Copy link
Contributor

sirhcel commented Dec 1, 2022

I learned that OpenBSD is currently just a tier 3 target for Rust and not available through rustup yet. So I see no trivial path for adding this target to our CI builds. In favor of getting your fix into the next path release (#70), I'd like to postpone adding CI builds for OpenBSD (with #71 or even a later issue).

Do you know of an OpenBSD CI build for Rust where I could have a look at @n1000?

Thank you very much for spotting this issue. Please keep your eyes open in the meanwhile. ;-)

@sirhcel sirhcel merged commit 9dc140c into serialport:main Dec 1, 2022
@n1000 n1000 deleted the openbsd_compilation_issue branch December 29, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants