Don't ignore errors from setting baud rates #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Don't you think we should tell them that this baud rate is not supported? Nah. Just smile and wave boys smile, smile and wave." While this makes great movies, this does not make setting a knowingly unsupported baud rate a great experience. At least when in comes to debugging. Play nice and report this and other errors related to baud rates back.
sirhcel
changed the title
eldruin
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A chat a while ago led to the discovery that we are currently silently ignoring attempts to set an unsupported baud rate on Linux/musl.
This PR changes the behavior to report an error in this case.
Even though this does not add the support, it will no longer keep users in the dark about this issue like it likely happened in #156.