Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usb): improve robustness of interface field when using IOKit backend #202

Closed

Conversation

doinkythederp
Copy link

@doinkythederp doinkythederp commented Jul 17, 2024

This PR improves the robustness of the code that finds the USB port interface number. Instead of accessing the nonexistent IOUSBHostDevice.bInterfaceNumber property, it accesses IOUSBHostInterface.bInterfaceNumber.

@doinkythederp
Copy link
Author

It actually looks like this has the same behavior as #193.

@sirhcel
Copy link
Contributor

sirhcel commented Jul 18, 2024

Thank you for spotting this issue and preparing a PR @doinkythederp!

It actually looks like this has the same behavior as #193.

I already integrated #193 and this should give the same results. Could you please give 5039050 a spin and reopen this PR if things aren't solved for you?

@sirhcel sirhcel closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants